Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

Jeremy Whiting jpwhiting at kde.org
Mon Oct 14 20:40:27 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112129/
-----------------------------------------------------------

(Updated Oct. 14, 2013, 1:40 p.m.)


Status
------

This change has been discarded.


Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and Sebastian K├╝gler.


Bugs: https://bugs.kde.org/show_bug.cgi?id=149479
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=149479


Repository: kdelibs


Description
-------

This is the other half of the fix for the listed bug.  I made Plasma::PackageStructure::metadata look in the only subdirectory of an extracted archive if there's only one subdirectory for the metadata.desktop file.


Diffs
-----

  plasma/packagestructure.cpp 71148e1a18227d9ca847cbffe385aaaad9c66c6b 

Diff: http://git.reviewboard.kde.org/r/112129/diff/


Testing
-------

The bug is fixed here with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is.


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131014/afaed3c6/attachment.htm>


More information about the kde-core-devel mailing list