Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

[Mark Gaiser]

> On Oct. 14, 2013, 12:52 p.m., David Faure wrote:
> > tier1/kcoreaddons/src/lib/jobs/kjob.h, line 372
> > <http://git.reviewboard.kde.org/r/113205/diff/3/?file=201072#file201072line372>
> >
> >     I wonder if the Qt/kdelibs coding style has something about indentation of pre-processor directives, I would have expected this to be left-aligned on column 0.

Do you want me to left align it for the commit? Both are OK with me, this simply looked better :)


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41714
-----------------------------------------------------------


On Oct. 14, 2013, 12:46 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113205/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 12:46 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The new signal/slot connection:
> connect(job, &KJob::result,...
> 
> does't like result to be private and throws an compile error:
> error: 'void KJob::result(KJob*)' is private
> 
> Making it public resolves the issue and makes this slot usable in the new syntax. In my case i wanted to use the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 
>   tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f 
> 
> Diff: http://git.reviewboard.kde.org/r/113205/diff/
> 
> 
> Testing
> -------
> 
> Works just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131014/a92335b5/attachment.htm>