Review Request 113205: Make KJob::result public for the new signal/slot syntax.

Mark Gaiser markg85 at gmail.com
Mon Oct 14 13:30:13 BST 2013



> On Oct. 14, 2013, 6:47 a.m., Kevin Ottens wrote:
> > Why do it just for result and not finished, suspended, resumed? We end up with both mechanisms for private signals in the same header otherwise.

Will do. Will update this patch shortly.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41670
-----------------------------------------------------------


On Oct. 12, 2013, 6:30 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113205/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2013, 6:30 p.m.)
> 
> 
> Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> The new signal/slot connection:
> connect(job, &KJob::result,...
> 
> does't like result to be private and throws an compile error:
> error: 'void KJob::result(KJob*)' is private
> 
> Making it public resolves the issue and makes this slot usable in the new syntax. In my case i wanted to use the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public.
> 
> 
> Diffs
> -----
> 
>   tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 
>   tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f 
> 
> Diff: http://git.reviewboard.kde.org/r/113205/diff/
> 
> 
> Testing
> -------
> 
> Works just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131014/687ac965/attachment.htm>


More information about the kde-core-devel mailing list