Review Request 113194: port away from KIcon in libs/taskmanager

Aleix Pol Gonzalez aleixpol at kde.org
Mon Oct 14 01:03:37 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113194/#review41669
-----------------------------------------------------------

Ship it!


Looks good to me, it's what you should be doing according to KDE5Porting.html

- Aleix Pol Gonzalez


On Oct. 10, 2013, 9:42 p.m., Alexander Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113194/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 9:42 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> port away from KIcon in libs/taskmanager
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/abstractgroupingstrategy.cpp 601fcd1d2b186f22d58c9def55fe9ae5b208d7c4 
>   libs/taskmanager/launcherconfig.cpp 8656dad5713eda3d472084d20bc42e372c066389 
>   libs/taskmanager/launcheritem.h 604f046bc4f3a72da9b1f60553ab1802bd251196 
>   libs/taskmanager/launcheritem.cpp 7d8e7af8ad90fc2289d8f897b2177d6f1fb4d5a0 
>   libs/taskmanager/launcherproperties.cpp 5db134b7da7cf89bd269349101258943519a78bc 
>   libs/taskmanager/startup.cpp 5524ea23845726b87f1238d9e324bed185399d2a 
>   libs/taskmanager/taskactions.cpp b87b3c02e61e9b91966fb2a909bdbd88c9f94a5d 
>   libs/taskmanager/taskgroup.cpp 7c8f1f16e322175e8ff0cd117b48311eb5d865f8 
> 
> Diff: http://git.reviewboard.kde.org/r/113194/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131014/e364e831/attachment.htm>


More information about the kde-core-devel mailing list