Review Request 113205: Make KJob::result public for the new signal/slot syntax.

Mark Gaiser markg85 at
Sat Oct 12 19:30:10 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 12, 2013, 6:30 p.m.)

Review request for KDE Frameworks, kdelibs, David Faure, and Kevin Ottens.


Updated patch according to comments.
I took the example from:,all,30337,4

Compiled, ran tests, ran my own test application and everything seems fine with the new signal/slot syntax.

Repository: kdelibs


The new signal/slot connection:
connect(job, &KJob::result,...

does't like result to be private and throws an compile error:
error: 'void KJob::result(KJob*)' is private

Making it public resolves the issue and makes this slot usable in the new syntax. In my case i wanted to use the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public.

Diffs (updated)

  tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 
  tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f 



Works just fine.


Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list