Review Request 113219: Fix struct initialization which is invalid for C++11

Christoph Feck christoph at maxiom.de
Sat Oct 12 19:27:34 BST 2013



> On Oct. 12, 2013, 6:23 p.m., Jiří Pinkava wrote:
> > Ship It!
> 
> Christoph Feck wrote:
>     Thanks Ji?í. If possible, please request commit rights to the KDE repositories, so you can commit yourself after each review. This simplifies the work for others.

reviewboard isn't even Unicode safe. In 2013 ASCII still rulez.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113219/#review41609
-----------------------------------------------------------


On Oct. 12, 2013, 3:10 p.m., Jiří Pinkava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113219/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2013, 3:10 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> One more small step to C++11 support for kde
> 
> 
> Diffs
> -----
> 
>   kjs/identifier.cpp 7126a88 
> 
> Diff: http://git.reviewboard.kde.org/r/113219/diff/
> 
> 
> Testing
> -------
> 
> build
> 
> 
> Thanks,
> 
> Jiří Pinkava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131012/4978dbcf/attachment.htm>


More information about the kde-core-devel mailing list