Review Request 113131: Added missing slot to bookmarksrunner.*
Commit Hook
null at kde.org
Sat Oct 12 18:34:05 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113131/#review41605
-----------------------------------------------------------
This review has been submitted with commit fd4269c99f9d6f3a52bac0013fe8dbf0ac3f9df7 by Dawit Alemayehu to branch KDE/4.11.
- Commit Hook
On Oct. 6, 2013, 3:51 p.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113131/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2013, 3:51 p.m.)
>
>
> Review request for kde-workspace.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> This trivial patch adds a missing slot, teardown, to bookmarksrunner.h to stop the following warning message in the logs:
>
> Object::connect: No such slot KDEBrowser::teardown()
> Object::connect: (sender name: 'Bookmarks')
>
>
> Diffs
> -----
>
> plasma/generic/runners/bookmarks/browsers/kdebrowser.h 3302e41
> plasma/generic/runners/bookmarks/bookmarksrunner.cpp b36ad7f
>
> Diff: http://git.reviewboard.kde.org/r/113131/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dawit Alemayehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131012/a4b5ef6d/attachment.htm>
More information about the kde-core-devel
mailing list