Review Request 113196: kdirwatch: include correct header for time_t and ino_t.
Nicolás Alvarez
nicolas.alvarez at gmail.com
Fri Oct 11 03:30:40 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113196/
-----------------------------------------------------------
Review request for kdelibs.
Repository: kdelibs
Description
-------
kdirwatch: include correct header for time_t and ino_t.
We were including sys/time.h and sys/param.h, but Windows doesn't have
them, and POSIX says those types are defined in sys/types.h.
This doesn't fix the build on Windows, but it's a step.
Diffs
-----
tier1/kcoreaddons/src/lib/io/kdirwatch_p.h 77c7d6d1f83f0c984043ed1c7e3a83a2e824d0c7
Diff: http://git.reviewboard.kde.org/r/113196/diff/
Testing
-------
Still builds and passes tests on Linux/gcc.
Still fails to build on Windows/MSVC2010 but not for this reason :)
Thanks,
Nicolás Alvarez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131011/b5adad27/attachment.htm>
More information about the kde-core-devel
mailing list