Review Request 110118: wrong path for plugin. ( doubling the plugin address cause the basepath to "" )

Ömer Fadıl Usta omerusta at gmail.com
Thu Oct 10 13:20:21 BST 2013



> On Oct. 10, 2013, 1:16 p.m., Albert Astals Cid wrote:
> > Was this commited?
> > Also isn't a whole remove in the middle a bit too dangerous?

I had also some suspicions so i delayed commiting for check it on different installed paths
on the other hand i forget to commit. so it didn't committed but i need to check it again
before committing it. maybe we need to discard this review request until i had time to check it again
and confirm if that bug still exists


- Ömer Fadıl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110118/#review41480
-----------------------------------------------------------


On April 21, 2013, 9:18 p.m., Ömer Fadıl Usta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110118/
> -----------------------------------------------------------
> 
> (Updated April 21, 2013, 9:18 p.m.)
> 
> 
> Review request for kde-workspace, Aaron J. Seigo and Marco Martin.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> plasma-desktop(7470)/libplasma Plasma::PackageStructure::setPath: "/home/usta/kde/inst/master/share/apps/plasma/packages/org.kde.desktop.activitymanager//org.kde.desktop.activitymanager" invalid, basePath is ""
> 
> it resets basePath due to double pluginname at the end of path.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/activitymanager/activitymanager.cpp 2ecb30d 
> 
> Diff: http://git.reviewboard.kde.org/r/110118/diff/
> 
> 
> Testing
> -------
> 
> After this patch that warning about invalid path is gone. I have checked that package->path() returning correct address now.
> 
> 
> Thanks,
> 
> Ömer Fadıl Usta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131010/b5194c6f/attachment.htm>


More information about the kde-core-devel mailing list