Review Request 113162: fix invalid type conversion (char vs. const char)
Jan Kundrát
jkt at flaska.net
Wed Oct 9 12:24:15 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113162/#review41425
-----------------------------------------------------------
You can even make it a `const char * const` to communicate that the actual pointer itself is const, too.
That said, in this particular case I would just use a hardcoded "HOME" in both getenv and setenv for simplicity, but I'm not a kdelibs developer.
- Jan Kundrát
On Oct. 7, 2013, 7:40 p.m., Jiří Pinkava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113162/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 7:40 p.m.)
>
>
> Review request for kdelibs.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> oneline fix: char -> const char
>
>
> Diffs
> -----
>
> kdecore/auth/kauthhelpersupport.cpp f99b64d
>
> Diff: http://git.reviewboard.kde.org/r/113162/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiří Pinkava
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131009/a8c7ef5f/attachment.htm>
More information about the kde-core-devel
mailing list