Review Request 112880: Added KColorSchemeToken class.

[Denis Kuplyakov]

> On Sept. 29, 2013, 4:24 p.m., David Faure wrote:
> > The name "token" surprises me a bit. Is this a usual naming scheme for accessing C++ classes from QML?
> > Otherwise I would think the QML code would want to just write KColorScheme.
> > 
> > Maybe the registration could be done in a static method, rather than letting the apps do it on their own?
> > 
> > The "NEED TO FIX" in the description can be removed, right?
> > 
> > About the branch: I see that the request is correctly for 5.0 - which means less merging trouble, so it sounds good to me :)
> >
> 
> Denis Kuplyakov wrote:
>     We can register it as KColorScheme for QML but in C++ it can't have such name as KColorScheme already exists. Token was first that came to my mind, maybe we can name it KColorSchemeQMLWrapper or smth like this?
>     
>     As Kevin suggested maybe it should be placed at some other place, not kdeui? I don't know all structure of kdelibs so I'm hope you will help me.
>     
>     Also how can I implement static registration, or what class I can investigate as example?
>     
>     I have removed NEED TO FIX...

What is kdelibs/experimental/libkdeclarative ?? Maybe KColorSchemeToken should be put there. Does anybody know something about this?


- Denis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review41002
-----------------------------------------------------------


On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2013, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt b439e04 
>   includes/CMakeLists.txt cdf0143 
>   includes/KColorSchemeToken PRE-CREATION 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> -------
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131008/aa48e863/attachment.htm>