Review Request 113127: Fix click on trash plasmoid when on desktop and widgets are unlocked

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113127/#review41362
-----------------------------------------------------------


This review has been submitted with commit 6f49908ee013c8515712b8dd9a1a9c73a14a6b74 by Wolfgang Bauer to branch KDE/4.11.

- Commit Hook


On Oct. 7, 2013, 8:36 a.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113127/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2013, 8:36 a.m.)
> 
> 
> Review request for kde-workspace, Plasma and Marco Martin.
> 
> 
> Bugs: 325330
>     http://bugs.kde.org/show_bug.cgi?id=325330
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Don't register the icon as a draggable with the applet.
> 
> This causes events to be intercepted which prevents launching the file manager when
> the applet is movable.
> 
> The same has been done for the icon plasmoid some time ago:
> http://commits.kde.org/kde-workspace/2a685d9a1d87d11680970cea88cdcc96da17d514
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/trash/trash.cpp d8007c0 
> 
> Diff: http://git.reviewboard.kde.org/r/113127/diff/
> 
> 
> Testing
> -------
> 
> - Add a trash plasmoid to the desktop, make sure widgets are unlocked.
> - Click on the trash
> - file manager gets started every time, without the patch nothing happens (most of the time).
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131007/7d3154e7/attachment.htm>