Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

Martin Bříza mbriza at
Mon Oct 7 17:06:16 BST 2013

This is an automatically generated e-mail. To reply, visit:

Review request for kde-workspace.

Repository: kde-workspace


Using the date selector in kcm_clock to set any date further than February 7, 2106 resulted in setting the time to ((time_t) (unsigned int) -1). This patch makes setting any date further than this to spit out an DateError.
Also, it's a seed for discussion regarding this KCM module as passing the values as QStrings and converting from/to time_t doesn't seem like a manageable solution to the problem.
Thanks for your opinions.


  kcontrol/dateandtime/dtime.cpp 518afe5 
  kcontrol/dateandtime/helper.cpp 9168db3 



Built and tested on Fedora 19 x86_64.


Martin Bříza

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list