Review Request 113139: Try to export include targets for Plasma as well
Stephen Kelly
steveire at gmail.com
Mon Oct 7 10:35:27 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113139/#review41324
-----------------------------------------------------------
Which kde-workspace branch should I use to test this?
src/plasma/CMakeLists.txt
<http://git.reviewboard.kde.org/r/113139/#comment30269>
The if-else shouldn't be needed. INSTALL_INTERFACE should already check if ${INCLUDE_INSTALL_DIR} is absolute.
- Stephen Kelly
On Oct. 7, 2013, 8:13 a.m., Ben Cooksley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113139/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2013, 8:13 a.m.)
>
>
> Review request for kdelibs, Plasma and Stephen Kelly.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Add include targets for KF5::plasma, which will hopefully contribute towards fixing the kde-workspace[master] build on build.kde.org.
> Unfortunately it isn't entirely successful as it seems camelcase headers are installed by KF5::plasma into include/KDE/Plasma/ but it should be a start...
>
>
> Diffs
> -----
>
> src/plasma/CMakeLists.txt b21fd7b
>
> Diff: http://git.reviewboard.kde.org/r/113139/diff/
>
>
> Testing
> -------
>
> In place on CI build system. Proper include path now given to compiler.
>
>
> Thanks,
>
> Ben Cooksley
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131007/6d2415a1/attachment.htm>
More information about the kde-core-devel
mailing list