Review Request 112982: copyToFile support for kio_smb

[Dawit Alemayehu]

> On Oct. 5, 2013, 12:12 p.m., Mark Gaiser wrote:
> > Hi Dawit,
> > 
> > Sorry for the late reply. I will test this patch out and report my findings later today. I guess this is the long awaited patch that improves the file copy speed from SMB to local.

Yes, amongst the other fixes I outlined above. Please note that this patch is currently only for one direction: smb -> file. I am working on the other half: file -> smb right now.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112982/#review41273
-----------------------------------------------------------


On Sept. 29, 2013, 4:10 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112982/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2013, 4:10 p.m.)
> 
> 
> Review request for KDE Runtime.
> 
> 
> Bugs: 291835
>     http://bugs.kde.org/show_bug.cgi?id=291835
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> The attach patch adds support for the following to kio_smb:
> 
> - copyToFile optimization so downloading files from window shares is faster.
> - partial download resumption as part of the copyToFile implementation.
> - preservation of modified file timstamp. Again as part of the copyToFile implementation.
> 
> Note that in this patch the latter two features only apply to "smb" -> "file" downloads. The second part of this patch will that will follow soon will add support for the other half, the "copyFromFile" optimization.
> 
> 
> Diffs
> -----
> 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/smb.protocol 654bcfb 
> 
> Diff: http://git.reviewboard.kde.org/r/112982/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131005/0de7b84b/attachment.htm>