Review Request 113056: Port ksgrd library to KF5

David Edmundson david at davidedmundson.co.uk
Thu Oct 3 10:39:52 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113056/#review41160
-----------------------------------------------------------



libs/ksysguard/ksgrd/SensorAgent.cpp
<http://git.reviewboard.kde.org/r/113056/#comment30200>

    #include <KLocalizedString>
    
    should work. 



libs/ksysguard/ksgrd/SensorAgent.cpp
<http://git.reviewboard.kde.org/r/113056/#comment30201>

    This line is rather important as it makes translations work.
    
    You are correct that it is now obsolete, but there is a new replacement that it should be ported to.
    
    see http://api.kde.org/frameworks/kdelibs-apidocs/tier2/ki18n/html/prg_guide.html#link_cat
    
    i.e 
    
    #define TRANSLATION_DOMAIN "ksgrd"
    #include <KLocalizedString>
    


- David Edmundson


On Oct. 3, 2013, 5:50 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113056/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2013, 5:50 a.m.)
> 
> 
> Review request for kde-workspace and Sebastian K├╝gler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Port ksgrd library to KF5,
> 
> I already pushed kDebug > qDebug changes with commit 03681a90
> 
> 
> Diffs
> -----
> 
>   libs/ksysguard/CMakeLists.txt b00d9ff 
>   libs/ksysguard/ksgrd/CMakeLists.txt 90f8a7d 
>   libs/ksysguard/ksgrd/SensorAgent.cpp f067d31 
>   libs/ksysguard/ksgrd/SensorManager.cpp f1657ee 
>   libs/ksysguard/ksgrd/SensorShellAgent.cpp df6b20f 
>   libs/ksysguard/ksgrd/SensorSocketAgent.cpp 5104e62 
> 
> Diff: http://git.reviewboard.kde.org/r/113056/diff/
> 
> 
> Testing
> -------
> 
> No tests, we can test this by porting systemmonitor dataengine later.
> 
> Tested, works as expected. https://git.reviewboard.kde.org/r/113072/
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131003/9bf70552/attachment.htm>


More information about the kde-core-devel mailing list