Review Request 112880: Added KColorSchemeToken class.

[Denis Kuplyakov]

> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote:
> > To get in this patch would benefit from being based on the frameworks branch and go into kdeclarative.
> 
> Kevin Ottens wrote:
>     Any chance for an update?
> 
> Denis Kuplyakov wrote:
>     Yes I will finish it, when have time. There are many pre-exams in university.
> 
> Kevin Ottens wrote:
>     Any news? we need to get in or discard all the old patches now.
> 
> Kevin Ottens wrote:
>     Last warning before getting discarded. Patches will soon not be accepted in kdelibs/frameworks in preparation of the repository split.
> 
> Denis Kuplyakov wrote:
>     Sorry, but I'm still very busy. What is deadline, and can I submit changes after repo-split?
> 
> Kevin Ottens wrote:
>     Re-submitting *after* the repository is perfectly fine. It will have to be a new review though. If you're fine with that we can just discard that one, and you can resubmit at your convenience post-split.

That's good, I think you can discard this.


- Denis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112880/#review42069
-----------------------------------------------------------


On Oct. 6, 2013, 7:24 p.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112880/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2013, 7:24 p.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> It is wrapper to access KColorScheme's methods from QML code.
> Also added Q_GADGET to KColorScheme to enable Q_ENUMS using, to make them accessible from QML code.
> 
> As it will be accepted, QML-clone of KgPopupItem will be posted for review to libkdegames, as it uses it to access KDE's color theme.
> 
> More info:
> * search for "KDE theme colors API for QML" thread at kdelibs and kdegames mailinglists *
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt b439e04 
>   includes/CMakeLists.txt cdf0143 
>   includes/KColorSchemeToken PRE-CREATION 
>   kdeui/colors/kcolorscheme.h 17570fd 
>   kdeui/colors/kcolorscheme.cpp a6650ac 
>   kdeui/colors/kcolorschemetoken.h PRE-CREATION 
>   kdeui/colors/kcolorschemetoken.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112880/diff/
> 
> 
> Testing
> -------
> 
> I've tested it with KReversi's deniskup/gsoc2013/newdesign branch.
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131129/e82baa35/attachment.htm>