Review Request 111851: Split KCModules into different Categories in KHelpcenter's navigation tree

[Burkhard Lück]

> On Nov. 22, 2013, 7:05 a.m., Ben Cooksley wrote:
> > khelpcenter/plugintraverser.cpp, line 95
> > <http://git.reviewboard.kde.org/r/111851/diff/1/?file=176031#file176031line95>
> >
> >     Do you intend on modifying the control modules used by Dolphin and Konqueror here to fit this? That sounds like something which will cause unintended breakages.
> >     
> >     Perhaps it might be wise to check their respective code to determine how they look up the modules they want to load?

As far as I understand the code, neither Dolphin nor Konqueror use X-KDE-ParentApp.

In dolphinsettingsdialog.cpp the pages are manually added to the configuration dialog

In konqmainwindow.cpp the pages are added e.g. via
addModule(KCModuleInfo(QString(fmModules[i])+".desktop"),fileManagementGroup);
where fmModules is a hardcoded list of desktop file names


> On Nov. 22, 2013, 7:05 a.m., Ben Cooksley wrote:
> > kcmshell/main.cpp, line 63
> > <http://git.reviewboard.kde.org/r/111851/diff/1/?file=176023#file176023line63>
> >
> >     System Settings doesn't look for control modules via X-KDE-ParentApp.
> >     
> >     It uses the following trader query instead:
> >     [X-KDE-System-Settings-Parent-Category] != ''

The list of modules you get from "kcmshell4 --list" is different from the list of modules in systemsettings.
Wirh or without the patch you get the same output from "kcmshell4 --list"


- Burkhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111851/#review44184
-----------------------------------------------------------


On Nov. 21, 2013, 11:50 a.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111851/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 11:50 a.m.)
> 
> 
> Review request for Documentation, KDE Runtime, Albert Astals Cid, Ben Cooksley, and David Faure.
> 
> 
> Bugs: 262935
>     http://bugs.kde.org/show_bug.cgi?id=262935
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> The KHelpcenter navigation tree has a top level item "Control Center Modules", 
> an unsorted list of all KCModules (>80 for a full kde main modules install from stable).
> This makes this item hardly usable, see https://bugs.kde.org/show_bug.cgi?id=262935
> 
> This patch implements:
> 
> A) Alphabetical sorting for "Control Center Modules"/"Foo Settings Modules" + "KInfoCenter" items
> 
> B) New / changed top level categories in the navigation tree:
> 
>    1) System Settings Modules -> replaces old "Control Center Modules"
>       items: see http://docs.kde.org/stable/en/kde-workspace/systemsettings/general.html
> 
>    2) Konqueror Settings Modules (see Konqueror settings dialog)
>       items: General, Performance, Bookmarks 
> 
>    3) Filemanager Settings Modules (see Konqueror/Dolphin settings dialog)
>       items:
>       File Management, View Modes, Navigation, Services, General, Trash
>       No File Associations, because it is already in System Settings Modules
> 
>    4) Browser Settings Modules (see Konqueror settings dialog)
>       items:
>       Web Browsing, Proxy, Appearance, AdBlocK Filters, Web Shortcuts, Cache, 
>       History, Cookies, Browser Identification, Java & JavaScript, Plugins
> 
>    5) Other Settings Modules
>       all other items like e.g. CGI Scripts from kde-runtime
> 
>    To make full use of these new/changed categories some kcm desktop files in other 
>    modules than kde-runtime need a change of X-KDE-ParentApp from kcontrol to konquerorcontrol,
>    browsercontrol, filemanagercontrol or othercontrol, but that is not part of this review.
>    As long as not all desktop files are fixed according to this patch or a necessary change in a 
>    desktop files is overlooked that KCM will be in System Settings Modules like now, but in sorted order.
> 
> C) Change wording from "Control Center Modules" to "System Settings Modules" and using 
>    "Foo Settings Modules" for the new categories.
>    Control Center is from KDE 3, we use System Settings nearly all over GUI and in the whole documentation. 
> 
> 
> Diffs
> -----
> 
>   kcmshell/main.cpp dab8fc6 
>   khelpcenter/navigator.cpp 7460cc8 
>   khelpcenter/plugins/CMakeLists.txt d09b869 
>   khelpcenter/plugins/browsercontrolmodules.desktop e69de29 
>   khelpcenter/plugins/filemanagercontrolmodules.desktop e69de29 
>   khelpcenter/plugins/kcontrolmodules.desktop 1813df3 
>   khelpcenter/plugins/konquerorcontrolmodules.desktop e69de29 
>   khelpcenter/plugins/othercontrolmodules.desktop e69de29 
>   khelpcenter/plugintraverser.cpp b0b0e78 
>   kioslave/cgi/kcmcgi/kcmcgi.desktop f49eeb9 
> 
> Diff: http://git.reviewboard.kde.org/r/111851/diff/
> 
> 
> Testing
> -------
> 
> Checked with one example each for konquerorcontrol, browsercontrol, filemanagercontrol 
> and othercontrol, see attached screenshot.
> 
> 
> File Attachments
> ----------------
> 
> New Categories in KHelpcenter navigation tree
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/08/03/khelpcenter1.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131128/cf6bb3f8/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-doc-english mailing list
kde-doc-english at kde.org
https://mail.kde.org/mailman/listinfo/kde-doc-english