Review Request 112463: Port SMB kioslave to KF5/Qt5

[Mark Gaiser]

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote:
> > It's been stalled for almost three months now, any chance to see progress or should it be discarded?
> 
> Mark Gaiser wrote:
>     No, it should most certainly not be disgarded. It was even working when i posted this post up for review.
>     
>     Dawit, how are you doing in the SMB improvements that you had in mind?
> 
> Dawit Alemayehu wrote:
>     Sorry, I forgot to inform you. I have already merged my changes into 4.12 and master branches.

Awesome! Then i will update this review asap with an up to date patch.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112463/#review44515
-----------------------------------------------------------


On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112463/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 7:16 p.m.)
> 
> 
> Review request for KDE Runtime and KDE Frameworks.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> This is the initial port! I added two TODO lines in the diff for parts where i'm not sure if I've ported them correctly.
> Also, i needed a change in FindSamba.cmake to even get the samba detection working. That reviewrequest is waiting here: https://git.reviewboard.kde.org/r/112448/ you're probably OK if you still use samba 3.x
> 
> Once i know that this is actually working then i will comment some qDebug lines.
> 
> 
> Diffs
> -----
> 
>   kioslave/CMakeLists.txt ff66ab6 
>   kioslave/smb/CMakeLists.txt a3a2265 
>   kioslave/smb/kio_smb.h 55efb44 
>   kioslave/smb/kio_smb.cpp 2c2523a 
>   kioslave/smb/kio_smb_auth.cpp 4d236b4 
>   kioslave/smb/kio_smb_browse.cpp fec6449 
>   kioslave/smb/kio_smb_config.cpp 81ce29c 
>   kioslave/smb/kio_smb_dir.cpp 5573266 
>   kioslave/smb/kio_smb_file.cpp 827a519 
>   kioslave/smb/kio_smb_internal.h b895b81 
>   kioslave/smb/kio_smb_internal.cpp 3c35583 
>   kioslave/smb/kio_smb_mount.cpp a5a7e8e 
> 
> Diff: http://git.reviewboard.kde.org/r/112463/diff/
> 
> 
> Testing
> -------
> 
> It compiles and gets loaded just fine. I tried testing this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131128/9bfa3d3a/attachment.htm>