Review Request 114105: kcm proxy: fix for noProxyFor setting when 'system proxy' type

[Andrea Iacovitti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114105/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 9:22 p.m.)


Review request for KDE Base Apps and Dawit Alemayehu.


Changes
-------

Updated "Testing Done:"


Repository: kde-baseapps


Description
-------

In case of 'system proxy' proxyType, NoProxyFor config key holds the name of the env variable (e.g. no_proxy) and not its value.
Because of this KProtocolManager::noProxyFor() can not be used to get NoProxyFor config setting in KProxyDialog::load(), as it returns the resolved value of the environment variable and not its name: i added helper method KSaveIOConfig::noProxyFor() to read that value directly from config file.
Also make sure to uncheck showEnvValueCheckBox before filling proxy edit fields with environment variable names in KProxyDialog::on_autoDetectButton_clicked().


Diffs
-----

  konqueror/settings/kio/kproxydlg.cpp e80afeb 
  konqueror/settings/kio/ksaveioconfig.h 2318198 
  konqueror/settings/kio/ksaveioconfig.cpp c822f7b 

Diff: http://git.reviewboard.kde.org/r/114105/diff/


Testing (updated)
-------

To reproduce the issue:
$ export no_proxy=kde.org
$ kcmshell4 proxy
choose "Use system proxy configuration", push "Auto Detect" button, close the gui interface and reopen it:
$ kcmshell4 proxy
see how Exceptions fields contains "kde.org" and not "no_proxy"


Thanks,

Andrea Iacovitti

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131127/41dc14f2/attachment.htm>