Review Request 113985: Remove no-ops in KCategorizedView

Yichao Yu yyc1992 at gmail.com
Wed Nov 27 09:52:37 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113985/
-----------------------------------------------------------

(Updated Nov. 27, 2013, 9:52 a.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs, David Faure, Rafael Fernández López, and Michael Pyne.


Repository: kdelibs


Description
-------

Remove operations on temporary returned objects.
These are no-ops and are not needed since they are already done in visualRect.


Diffs
-----

  kdeui/itemviews/kcategorizedview.cpp 010bcbc 

Diff: http://git.reviewboard.kde.org/r/113985/diff/


Testing
-------

It compiles.

(It compiles when just adding const to the QRect, proving they are indeed no-op's).


Thanks,

Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131127/92a63450/attachment.htm>


More information about the kde-core-devel mailing list