Review Request 113985: Remove no-ops in KCategorizedView

[Yichao Yu]

> On Nov. 25, 2013, 1:35 p.m., David Faure wrote:
> > Ship It!

Thanks for the review. However, I don't have a git account yet and I cannot find others to push it for me this time. Could you please push it for me?


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113985/#review44451
-----------------------------------------------------------


On Nov. 21, 2013, 8:34 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113985/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 8:34 p.m.)
> 
> 
> Review request for kdelibs, David Faure, Rafael Fernández López, and Michael Pyne.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Remove operations on temporary returned objects.
> These are no-ops and are not needed since they are already done in visualRect.
> 
> 
> Diffs
> -----
> 
>   kdeui/itemviews/kcategorizedview.cpp 010bcbc 
> 
> Diff: http://git.reviewboard.kde.org/r/113985/diff/
> 
> 
> Testing
> -------
> 
> It compiles.
> 
> (It compiles when just adding const to the QRect, proving they are indeed no-op's).
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131127/4a128866/attachment.htm>