Review Request 113866: kio bookmarks: Only iterate over element nodes in findToolbar()

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113866/#review44510
-----------------------------------------------------------

Ship it!


Looks good, just one improvement below:


kio/bookmarks/kbookmark.cc
<http://git.reviewboard.kde.org/r/113866/#comment31793>

    firstChildElement returns a QDomElement, you should declare the variable as such, to avoid the toElement() call below.


- David Faure


On Nov. 15, 2013, 2:06 p.m., Stefan Brüns wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113866/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2013, 2:06 p.m.)
> 
> 
> Review request for kdelibs and Frank Reininghaus.
> 
> 
> Bugs: 320006
>     http://bugs.kde.org/show_bug.cgi?id=320006
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Only iterate over element nodes, and filter on <folder> tag.
> 
> findFirstChild/nextSibling might return a node which is not an QDomElement. toElement will return NULL and accessing it will crash.
> 
> Possible fix for 320006
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmark.cc 8459a02 
> 
> Diff: http://git.reviewboard.kde.org/r/113866/diff/
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Stefan Brüns
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131126/ffbf7fcb/attachment.htm>