Review Request 114017: Fix crash with horizontal wheel on tabs

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114017/#review44503
-----------------------------------------------------------


looks like the tabwidget sends an event to one of its own children (tabbar())
As long as the chlild does not accept the event, it's gonna be passed on and received by the tabwidget again what will cause a recursion.

Since QTabWidget::setTabBar() is protected and could be used by any KTabWidget inheritor, one can actually not rely on the tabbar() to accept the event (no matter of it's attributes, but this also includes eg. modifiers), thus I guess what is really needed here is a recursion protection flag around the sendEvent - sorry :(

- Thomas Lübking


On Nov. 26, 2013, 11:29 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114017/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 11:29 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Bugs: 314082
>     http://bugs.kde.org/show_bug.cgi?id=314082
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Details at bug 314082.
> 
> From how I understand the problem, we should not sent the fake event for horizontal scrolling, because it is not handled by the tabbar code. Someone please confirm it fixes the problem.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/ktabwidget.cpp 49dc293 
> 
> Diff: http://git.reviewboard.kde.org/r/114017/diff/
> 
> 
> Testing
> -------
> 
> Fixes the crash, according to a tester.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131126/523a3798/attachment.htm>