Review Request 111238: Remove <iterator>.end() calls from iteration loops in KDirLister

Dawit Alemayehu adawit at kde.org
Sun Nov 17 04:15:42 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111238/
-----------------------------------------------------------

(Updated Nov. 17, 2013, 4:15 a.m.)


Status
------

This change has been discarded.


Review request for kdelibs and David Faure.


Repository: kdelibs


Description
-------

The attached patch removes <iterator>.end() from for and while loops in kdirlister.cpp. I made the change only when it can be done safely. The for loops that had the .end() calls in them were replaced with a Q_FOREACH statement.


Diffs
-----

  kio/kio/kdirlister.cpp d66c324 

Diff: http://git.reviewboard.kde.org/r/111238/diff/


Testing
-------

Run the unit test.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131117/7e05052d/attachment.htm>


More information about the kde-core-devel mailing list