Review Request 112982: copy[To|From]File support for kio_smb

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112982/
-----------------------------------------------------------

(Updated Nov. 15, 2013, 11:59 a.m.)


Review request for KDE Runtime and David Faure.


Changes
-------

Updated patch based on feedback and testing.

Not sure what to do about the fact that this patch requires new API available only in kdelibs >= 4.11.80.
Should I change the required package in the CMakeLists.txt file or #ifdef the code?


Bugs: 176271 and 291835
    http://bugs.kde.org/show_bug.cgi?id=176271
    http://bugs.kde.org/show_bug.cgi?id=291835


Repository: kde-runtime


Description
-------

The attach patch adds support for the following to kio_smb:

- copyToFile/copyFromFile optimizations so uploading and downloading files from window shares is faster so long as one end is a local file.
- partial download resumption as part of the copyToFile implementation.
- preservation of modified file timstamp. Again as part of the copyToFile implementation.


Diffs (updated)
-----

  kioslave/smb/kio_smb.h 55efb44 
  kioslave/smb/kio_smb_dir.cpp 186b687 
  kioslave/smb/kio_smb_internal.h b895b81 
  kioslave/smb/kio_smb_internal.cpp 3c35583 
  kioslave/smb/smb.protocol 654bcfb 

Diff: http://git.reviewboard.kde.org/r/112982/diff/


Testing (updated)
-------

- Copied files to and from smb share.
- Resumed interrupted file copy to and from smb share.


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131115/107b7af9/attachment.htm>