Review Request 113413: Improved Keyboard Layout Preview

[shivam makkar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113413/
-----------------------------------------------------------

(Updated Nov. 15, 2013, 9:37 a.m.)


Review request for KDE Runtime, kde-workspace and Andriy Rysin.


Changes
-------

fixed the position of 3/4 level key symbols and the warning in kbpreviewframe


Repository: kde-workspace


Description
-------

Improved keyboard layout preview 
added geometry feature, multi-level keys (>4) and parsed geometry file using Boost c++ libraries and tool tip showing symbol names.
my GSoC-13 project !


Diffs (updated)
-----

  kcontrol/keyboard/preview/kbpreviewframe.cpp 2d7a11e 

Diff: http://git.reviewboard.kde.org/r/113413/diff/


Testing
-------


File Attachments (updated)
----------------

English layout default geometry
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/05/57ce3e15-26a9-46e2-ad5d-6073e04a5489__snapshot16.jpg
ukranian layout fixed 3/4 levels
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/527ada38-46b1-4b96-9d03-4a429d8275a5__snapshot19.jpg
belgian fixed 3/4 level
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/1ec53ee9-f2ac-4a63-bc4f-6180160c20dd__snapshot20.jpg
microsoft natural 
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/15/aea0136b-c4f2-412e-9de7-534b64d70af0__snapshot18.jpg


Thanks,

shivam makkar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131115/a8344771/attachment.htm>