Review Request 113853: port kcm icons to KF5

[Jonathan Riddell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113853/
-----------------------------------------------------------

(Updated Nov. 14, 2013, 4:26 p.m.)


Review request for KDE Runtime and Sebastian Kügler.


Changes
-------

fix issues sebas mentioned
reenable and port the test
use KIconLoader::emitChange instead of deprecated KGlobalSettings::self()->emitChange


Repository: kde-runtime


Description
-------

port kcm icons to Qt 5 and KF 5


Diffs (updated)
-----

  kcontrol/icons/iconthemes.h 7352c21 
  kcontrol/icons/iconthemes.cpp 9899686 
  kcontrol/icons/main.h 066080d 
  kcontrol/icons/main.cpp c98d78a 
  kcontrol/icons/tests/CMakeLists.txt 2199068 
  kcontrol/icons/tests/testicons.cpp eae44b1 
  kcontrol/icons/CMakeLists.txt b16a52b 
  kcontrol/icons/icons.cpp 3813651 
  kcontrol/icons/icons.desktop d594788 
  kcontrol/icons/icons.h 1217c99 
  kcontrol/CMakeLists.txt 6e6d593 

Diff: http://git.reviewboard.kde.org/r/113853/diff/


Testing
-------


Thanks,

Jonathan Riddell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131114/5efa1fdf/attachment.htm>