Review Request 113853: port kcm icons to KF5

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113853/#review43666
-----------------------------------------------------------


Nice.

The QFormLayout doesn't need to be replaced, see the comment inline.

Did you test if switching icons works with this? Are changes being picked up at run-time?


kcontrol/icons/icons.cpp
<http://git.reviewboard.kde.org/r/113853/#comment31375>

    This looks scary?



kcontrol/icons/icons.cpp
<http://git.reviewboard.kde.org/r/113853/#comment31376>

    extraneous whitespace



kcontrol/icons/icons.cpp
<http://git.reviewboard.kde.org/r/113853/#comment31377>

    Set the verticalSpacing property in QFormLayout like this in the ui file: 
    
    <property name="verticalSpacing">
    <number>0</number>
    </property>
    
    More info here: https://bugreports.qt-project.org/browse/QTBUG-34731



kcontrol/icons/iconthemes.cpp
<http://git.reviewboard.kde.org/r/113853/#comment31378>

    ws



kcontrol/icons/iconthemes.cpp
<http://git.reviewboard.kde.org/r/113853/#comment31379>

    ws



kcontrol/icons/main.cpp
<http://git.reviewboard.kde.org/r/113853/#comment31380>

    ws


- Sebastian Kügler


On Nov. 14, 2013, 11:15 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113853/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 11:15 a.m.)
> 
> 
> Review request for KDE Runtime and Sebastian Kügler.
> 
> 
> Repository: kde-runtime
> 
> 
> Description
> -------
> 
> port kcm icons to Qt 5 and KF 5
> 
> 
> Diffs
> -----
> 
>   kcontrol/CMakeLists.txt 6e6d593 
>   kcontrol/icons/CMakeLists.txt b16a52b 
>   kcontrol/icons/icons.cpp 3813651 
>   kcontrol/icons/icons.desktop d594788 
>   kcontrol/icons/icons.h 1217c99 
>   kcontrol/icons/iconthemes.h 7352c21 
>   kcontrol/icons/iconthemes.cpp 9899686 
>   kcontrol/icons/main.h 066080d 
>   kcontrol/icons/main.cpp c98d78a 
> 
> Diff: http://git.reviewboard.kde.org/r/113853/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131114/4629dba5/attachment.htm>