Review Request 113785: Fix Mozilla bookmark importing

Dawit Alemayehu adawit at kde.org
Sun Nov 10 17:00:02 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113785/
-----------------------------------------------------------

(Updated Nov. 10, 2013, 5 p.m.)


Status
------

This change has been marked as submitted.


Review request for kdelibs and David Faure.


Bugs: 292495
    http://bugs.kde.org/show_bug.cgi?id=292495


Repository: kdelibs


Description
-------

Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded by the <HR> element resulting in lines like 

<HR>    <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3>

simply being treated as a separator instead of a separator followed by a bookmark entry. The attached patch addresses this problem.


Diffs
-----

  kio/bookmarks/kbookmarkimporter_ns.cc d3f0eaa 

Diff: http://git.reviewboard.kde.org/r/113785/diff/


Testing
-------


Thanks,

Dawit Alemayehu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131110/98b290fb/attachment.htm>


More information about the kde-core-devel mailing list