Review Request 113785: Fix Mozilla bookmark importing

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113785/#review43352
-----------------------------------------------------------

Ship it!



kio/bookmarks/kbookmarkimporter_ns.cc
<http://git.reviewboard.kde.org/r/113785/#comment31228>

    (could be more optimized with startsWith("<HR>", Qt::CaseInsensitive) -- but ok, the rest of the code uses toUpper, so this is ok for this commit)


- David Faure


On Nov. 10, 2013, 2:51 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113785/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2013, 2:51 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Bugs: 292495
>     http://bugs.kde.org/show_bug.cgi?id=292495
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> Currently the Mozilla bookmark importing code simply ignores any HTML tags preceded by the <HR> element resulting in lines like 
> 
> <HR>    <DT><H3 ADD_DATE="1364760832" LAST_MODIFIED="1364760921">magie</H3>
> 
> simply being treated as a separator instead of a separator followed by a bookmark entry. The attached patch addresses this problem.
> 
> 
> Diffs
> -----
> 
>   kio/bookmarks/kbookmarkimporter_ns.cc d3f0eaa 
> 
> Diff: http://git.reviewboard.kde.org/r/113785/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131110/69921068/attachment.htm>