Review Request 113779: KInfocenter/OpenGL: fix ReadPipe() in the case that the command cannot be run

[Rolf Eike Beer]

> ReadPipe() doesn't return 0 as expected in the case that the command is not
> found. but the length of sh's output which is "command not found" in this
> case. This is because popen() does not fail if the command is not found,
> because it _can_ run "sh". (according to the man page, popen calls "/bin/sh
> -c command") To fix this, ReadPipe() should check the return code of the
> call to pclose() (see "man pclose"), and return 0 if this is not equal to
> 0.

Can't this be ported to simply use QProcess instead?

Eike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131110/93673f71/attachment.sig>