Review Request 113644: Fix Standalone Build for KWallet
Aurélien Gâteau
agateau at kde.org
Tue Nov 5 13:51:47 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113644/#review43056
-----------------------------------------------------------
Looks good, thanks!
Note: you should use the "kdeframeworks" group instead of the "kdelibs" group for KF5 review requests.
- Aurélien Gâteau
On Nov. 5, 2013, 2:36 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113644/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 2:36 p.m.)
>
>
> Review request for kdelibs and Aurélien Gâteau.
>
>
> Repository: kdelibs
>
>
> Description
> -------
>
> Fix name of package to find.
>
>
> Diffs
> -----
>
> tier2/kwallet/CMakeLists.txt 8700907
>
> Diff: http://git.reviewboard.kde.org/r/113644/diff/
>
>
> Testing
> -------
>
> 1. Configure a standalone build for kwallet
>
> Before this patch, CMake would fail to find package KConfigCore
>
>
> Thanks,
>
> David Narváez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131105/f19afd43/attachment.htm>
More information about the kde-core-devel
mailing list