Review Request 113630: Port the original KDE4 ksplash theme to QML

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113630/
-----------------------------------------------------------

(Updated Nov. 5, 2013, 10:42 a.m.)


Review request for kde-workspace.


Changes
-------

Fixed Kai's comments.


Repository: kde-workspace


Description
-------

Last thing on my ksplash list is to port the good old KDE4 theme as "Classic" theme done in QML. I'm a QML noob so I'm putting it up for some comments. It works (and looks) just like the original theme. I reconstructed it using the original images.

I'll put it into kde-workspace/ksplash, where it can be further improved, then it can be moved to some Look&Feel package later on.


Diffs (updated)
-----

  ksplash/ksplashqml/themes/CMakeLists.txt c5ab367 
  ksplash/ksplashqml/themes/Classic/CMakeLists.txt PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/Preview.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/Theme.rc PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/images/background.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/images/icon1.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/images/icon2.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/images/icon3.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/images/icon4.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/images/icon5.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/images/rectangle.png PRE-CREATION 
  ksplash/ksplashqml/themes/Classic/main.qml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/113630/diff/


Testing
-------

Works just like in KDE4.


File Attachments
----------------

Screenshot
  http://git.reviewboard.kde.org/media/uploaded/files/2013/11/04/b7596f8c-2df3-4e62-bcbd-ee0e5ad5afc4__ksplash_classic.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131105/0a235bca/attachment.htm>