Review Request 113630: Port the original KDE4 ksplash theme to QML

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113630/#review43036
-----------------------------------------------------------


Didn't test.
But it doesn't have that fancy fade-blur-in transition :)


ksplash/ksplashqml/themes/Classic/main.qml
<http://git.reviewboard.kde.org/r/113630/#comment31036>

    Do we even need this? It's not like the splash did or would ever be resolution independent



ksplash/ksplashqml/themes/Classic/main.qml
<http://git.reviewboard.kde.org/r/113630/#comment31037>

    David Edmundson put so much effort into making the switch from LightDm to the session as seamless as possible and now you make it black and fade in the wallpaper again? ;)



ksplash/ksplashqml/themes/Classic/main.qml
<http://git.reviewboard.kde.org/r/113630/#comment31038>

    Then we don't need this?



ksplash/ksplashqml/themes/Classic/main.qml
<http://git.reviewboard.kde.org/r/113630/#comment31040>

    anchors.centerIn: main



ksplash/ksplashqml/themes/Classic/main.qml
<http://git.reviewboard.kde.org/r/113630/#comment31041>

    Not needed, you're not scaling or transforming the images


- Kai Uwe Broulik


On Nov. 4, 2013, 8:22 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113630/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 8:22 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> Last thing on my ksplash list is to port the good old KDE4 theme as "Classic" theme done in QML. I'm a QML noob so I'm putting it up for some comments. It works (and looks) just like the original theme. I reconstructed it using the original images.
> 
> I'll put it into kde-workspace/ksplash, where it can be further improved, then it can be moved to some Look&Feel package later on.
> 
> 
> Diffs
> -----
> 
>   ksplash/ksplashqml/themes/CMakeLists.txt c5ab367 
>   ksplash/ksplashqml/themes/Classic/CMakeLists.txt PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/Preview.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/Theme.rc PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/images/background.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/images/icon1.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/images/icon2.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/images/icon3.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/images/icon4.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/images/icon5.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/images/rectangle.png PRE-CREATION 
>   ksplash/ksplashqml/themes/Classic/main.qml PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113630/diff/
> 
> 
> Testing
> -------
> 
> Works just like in KDE4.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/11/04/b7596f8c-2df3-4e62-bcbd-ee0e5ad5afc4__ksplash_classic.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20131105/5960ff24/attachment.htm>