Review Request 109611: Add option to show "Recently Installed" apps in kickoff plasmoid

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109611/#review33248
-----------------------------------------------------------

Ship it!


Looks ok to me, just minor style issues. I don't maintain that code at all, but if nobody else reacts, I think you can commit.


plasma/desktop/applets/kickoff/core/applicationmodel.cpp
<http://git.reviewboard.kde.org/r/109611/#comment24596>

    const QString &  (the ref is missing)



plasma/desktop/applets/kickoff/core/applicationmodel.cpp
<http://git.reviewboard.kde.org/r/109611/#comment24597>

    missing space after "if"



plasma/desktop/applets/kickoff/core/applicationmodel.cpp
<http://git.reviewboard.kde.org/r/109611/#comment24598>

    no space between ) and ).


- David Faure


On May 19, 2013, 9:41 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109611/
> -----------------------------------------------------------
> 
> (Updated May 19, 2013, 9:41 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> (This comes from a patch included in openSUSE)
> 
> This patch makes kickoff remember all the .desktop files it sees (in kickoffrc). 
> New ones are additionally shown in a seperate submenu named "Recently Installed" (for 3 days).
> 
> The seen entries are saved as "id=date" pairs in the "Seen Applications" group.
> Entries older than 3 days get their date set to empty, which means "don't show this entry anymore".
> Also if there have no entries been saved yet, the date of all found entries is set to empty as well. This prevents that all menu entries are shown in the "Recently Installed" submenu on first start.
> 
> The "Recently Installed" submenu can be toggled on and off in the plasmoid's settings.
> 
> 
> This addresses bug 316916.
>     http://bugs.kde.org/show_bug.cgi?id=316916
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/kickoff/applet/applet.cpp a6f7379 
>   plasma/desktop/applets/kickoff/applet/kickoffConfig.ui 8664ac8 
>   plasma/desktop/applets/kickoff/core/applicationmodel.h f0f8872 
>   plasma/desktop/applets/kickoff/core/applicationmodel.cpp 57b6ba5 
>   plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 28fba18 
>   plasma/desktop/applets/kickoff/ui/launcher.h 2a234c3 
>   plasma/desktop/applets/kickoff/ui/launcher.cpp 4425bcc 
> 
> Diff: http://git.reviewboard.kde.org/r/109611/diff/
> 
> 
> Testing
> -------
> 
> Created a new .desktop file in ~/.local/share/applications, ran kbuildsycoca4 and the menu "Recently Installed" appeared with this entry.
> After logout/login this is still present.
> Deleted the .desktop file again, ran kbuildsycoca4 and the menu "Recently Installed" disappeared again.
> 
> I have been using the (vanilla KDE) kickoff applet with this patch for about a week now.
> 
> Also this patch is already part of openSUSE for several years...
> 
> 
> File Attachments
> ----------------
> 
> Settings dialog (kickoff style) with patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/kickoff-settings.png
> Plasmoid (kickoff style) showing the "Recently Installed" submenu
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/kickoff.png
> Settings dialog (classic style) with patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/classic-settings.png
> Plasmoid (classic style) showing the "Recently Installed" submenu
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/04/02/classic.png
> sample kickoffrc written by this patch
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/19/kickoffrc
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130527/b69a1ccc/attachment.htm>