Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110390/#review33212
-----------------------------------------------------------


This review has been submitted with commit 625b40da4fea11b6a20cd45df29d8697d110a637 by Jan Grulich to branch master.

- Commit Hook


On May 27, 2013, 11:24 a.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110390/
> -----------------------------------------------------------
> 
> (Updated May 27, 2013, 11:24 a.m.)
> 
> 
> Review request for KDE Runtime, Casian Andrei, Colin Guthrie, and Harald Sitter.
> 
> 
> Description
> -------
> 
> This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. Previous solution emits ready() signal when some parts of AudioSetup are not initialized yet. And changed() signal is connected to soon so that's the reason why this KCM is always set as changed.
> 
> 
> Diffs
> -----
> 
>   phonon/kcm/audiosetup.cpp 35dc4ca 
>   phonon/kcm/main.cpp 5d75cba 
> 
> Diff: http://git.reviewboard.kde.org/r/110390/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130527/0a94c171/attachment.htm>