Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

[Michel Ludwig]

> On May 23, 2013, 9:16 a.m., Patrick von Reth wrote:
> > Sorry for the missing feedback we already apply your patch locally and its already part of our release so please ship it.
> > 
> > BIG THANKS
> 
> Michel Ludwig wrote:
>     Ok. As I haven't done any commits to kdelibs in a while, does anybody know what the current commit policy is, i.e. to which branch(es) should I commit?
> 
> Aleix Pol Gonzalez wrote:
>     You should commit to KDE/4.10. It's a fix anyway, no?

Yes, committing to KDE/4.10 is fine. But what about other branches, like 'master' or 'framework'. Commit, cherry-pick, merge, or nothing of the three? :)


- Michel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109246/#review33017
-----------------------------------------------------------


On March 2, 2013, 4:54 p.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109246/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 4:54 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Absolute paths can, for example, have the form "E:/MyDocuments/test/test.tex" on Windows. Currently, KUrl::_relativePath assumes that 
> "E:/MyDocuments/test/test.tex" is a relative path and
> 
>   KUrl::relativePath("E:/MyDocuments/", "E:/MyDocuments/test/test.tex") 
> 
> will therefore return "E:/MyDocuments/test/test.tex" instead of "test/test.tex". The attached patch fixes this issue.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kurl.cpp ef2ba12 
> 
> Diff: http://git.reviewboard.kde.org/r/109246/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130524/ab5a1548/attachment.htm>