Review Request 109246: Make KUrl::relativePath and KUrl::relativeUrl work correctly on Windows

[Patrick Spendrin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109246/#review33016
-----------------------------------------------------------

Ship it!


We have this fix already in the kdelibs-4.10.2 diff in emerge, there is another one in there which might also interest you.

- Patrick Spendrin


On March 2, 2013, 4:54 p.m., Michel Ludwig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109246/
> -----------------------------------------------------------
> 
> (Updated March 2, 2013, 4:54 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Absolute paths can, for example, have the form "E:/MyDocuments/test/test.tex" on Windows. Currently, KUrl::_relativePath assumes that 
> "E:/MyDocuments/test/test.tex" is a relative path and
> 
>   KUrl::relativePath("E:/MyDocuments/", "E:/MyDocuments/test/test.tex") 
> 
> will therefore return "E:/MyDocuments/test/test.tex" instead of "test/test.tex". The attached patch fixes this issue.
> 
> 
> Diffs
> -----
> 
>   kdecore/io/kurl.cpp ef2ba12 
> 
> Diff: http://git.reviewboard.kde.org/r/109246/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michel Ludwig
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130523/577aa684/attachment.htm>