Review Request 110529: more error handling in KIdleTime

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110529/#review32795
-----------------------------------------------------------

Ship it!


Looks good, just whitespace issues to fix before committing.


tier1/kidletime/src/kidletime.cpp
<http://git.reviewboard.kde.org/r/110529/#comment24353>

    wrong indentation change?



tier1/kidletime/src/kidletime.cpp
<http://git.reviewboard.kde.org/r/110529/#comment24354>

    space after if



tier1/kidletime/src/kidletime.cpp
<http://git.reviewboard.kde.org/r/110529/#comment24355>

    space after if (and there's more below)


- David Faure


On May 20, 2013, 3:25 a.m., Ian Monroe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110529/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 3:25 a.m.)
> 
> 
> Review request for KDE Frameworks and kdelibs.
> 
> 
> Description
> -------
> 
> more error handling in KIdleTime
> 
> Segfaults could result in some rare circumstances
> 
> 
> Diffs
> -----
> 
>   tier1/kidletime/src/xsyncbasedpoller.cpp e5f5328ae66d44e9224582ad759207bc42333d80 
>   tier1/kidletime/src/kidletime.cpp fe18ee5d5c4525086a56d99e76e8ea0a4a92ce08 
> 
> Diff: http://git.reviewboard.kde.org/r/110529/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Monroe
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130520/31ebee7d/attachment.htm>