Review Request 103555: Fix for stale permissions information in properties dialog

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103555/#review32773
-----------------------------------------------------------


Looks good, just a few minor things to fix.


kio/kio/kdirlister.cpp
<http://git.reviewboard.kde.org/r/103555/#comment24344>

    This should only be called if _dir.isLocalFile(). Needs to be added in one of the if()s above.



kio/kio/kdirlister.cpp
<http://git.reviewboard.kde.org/r/103555/#comment24345>

    No need for double-lookup. Remove the if(), insert() will do nothing if this path is already in the QSet.



kio/tests/kdirlistertest.cpp
<http://git.reviewboard.kde.org/r/103555/#comment24347>

    QVERIFY(job->exec());



kio/tests/kdirlistertest.cpp
<http://git.reviewboard.kde.org/r/103555/#comment24346>

    Use QCOMPARE() so that failures are easier to debug.


- David Faure


On May 18, 2013, 11:20 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103555/
> -----------------------------------------------------------
> 
> (Updated May 18, 2013, 11:20 p.m.)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Description
> -------
> 
> If you open a directory that contains other directories in Konqueror or Dolphin, change the permission of one of these directories from outside, say the command line, and right click on the same directory to look at the permission tab in the properties dialog, you will see that the permission change has not been updated. This patch addresses that bug.
> 
> 
> This addresses bug 173733.
>     http://bugs.kde.org/show_bug.cgi?id=173733
> 
> 
> Diffs
> -----
> 
>   kio/kio/kdirlister.cpp 94b1d1d 
>   kio/tests/kdirlistertest.h 1b117bb 
>   kio/tests/kdirlistertest.cpp a0b296d 
> 
> Diff: http://git.reviewboard.kde.org/r/103555/diff/
> 
> 
> Testing
> -------
> 
> 1. In konsole, create a test directory within another test directory:
>      mkdir -p test/test1
> 
> 2. Open Dolphin or Konqueror and navigate to "test".
>    
> 3. In konsole, cd into the first test directory:
>      cd test
> 
> 4. In konsole, change the permission of 'test1'. For example,
>      chmod go-rx
> 
> 5. In the open Dolphin or Konqueror, right click on "test1", select properties and click on permission tab.
> 
> 6. Validate whether or not the permission shown in the GUI matches what you see in the command line.
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130519/9bd61b21/attachment.htm>