Review Request 110367: Add JoinTheGame menu entry

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110367/#review32763
-----------------------------------------------------------


This caused an unhandled switch warning in kdoctools/genshortcutents.cpp, which can be trivially fixed with:

diff --git a/kdoctools/genshortcutents.cpp b/kdoctools/genshortcutents.cpp
index b35b5a4..92bdea5 100644
--- a/kdoctools/genshortcutents.cpp
+++ b/kdoctools/genshortcutents.cpp
@@ -300,6 +300,9 @@ static QString entityForAccel( KStandardShortcut::StandardShortcut accel )
                case KStandardShortcut::AboutKDE:
                        markup += "AboutKDE";
                        break;
+               case KStandardShortcut::JoinTheGame:
+                       markup += "JoinTheGame";
+                       break;
                case KStandardShortcut::StandardShortcutCount:
                        break;
        }

however I'm not sure if there is anything else needed for the doc tools. This additional patch allowed kdelibs docs to build just fine so I don't think there are additional XML schemas to modify, however it might be prudent to check.

-----------

As a separate point though, I must admit to being nervous about the idea of integrating this into *every* KDE-using app's UI, including applications that have no affiliation with KDE whatsoever other than using kdelibs.

How would we as devs/GNU-users react if the default bash prompt contained a notice on how to fund the FSF?

Additionally even if we assume that users of KDE software wish to fund contributor meetings, necessary infrastructure, and the future security of KDE software, it doesn't necessarily follow that they wish to e.g. raise awareness for Free Culture.

In any event I would recommend avoiding "baking in" a donation amount or method in the U/I, it may change in the future.

------------

I don't want to splash cold water on the idea because I think this kind of promo activity can be very useful, but I don't think this is the right format. I would recommend a separate app or Plasmoid that can be run with a way to link it from the Plasma desktop (which *does* belong to KDE), preferably not quite as obtrusively.

We're currently riding a relative wave of positive karma with FOSS users for the first time in years and I don't want to see KDE exposed to the same reaction that we've seen with Ubuntu's Amazon gem or earlier with KDE 4.0. I've grown fond of not having flamewars about cashews or JRTs and I wish to see that continue if possible. :)


kdeui/dialogs/kjointhegamedialog_p.cpp
<http://git.reviewboard.kde.org/r/110367/#comment24335>

    "activities do so" is wrong, I'm not sure what exactly is meant though.


- Michael Pyne


On May 9, 2013, 11:05 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110367/
> -----------------------------------------------------------
> 
> (Updated May 9, 2013, 11:05 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> Patch by Pau ages ago, Lydia wants to push for it again.
> 
> Note that i still find it ugly, but i'm not the kdeui maintainer, so i'll leave it to someone else to discuss.
> 
> Not sure if the StandardAction enum addition should be at the end in case someone is storing those enums in a file or something.
> 
> 
> Diffs
> -----
> 
>   kdecore/doc/README.kiosk b95002d 
>   kdeui/CMakeLists.txt b439e04 
>   kdeui/actions/kstandardaction.h 3064301 
>   kdeui/actions/kstandardaction.cpp 7de0c6f 
>   kdeui/actions/kstandardaction_p.h b8f8df1 
>   kdeui/dialogs/jointhegame.png PRE-CREATION 
>   kdeui/dialogs/kaboutkdedialog_p.cpp b9728bf 
>   kdeui/dialogs/kjointhegamedialog_p.h PRE-CREATION 
>   kdeui/dialogs/kjointhegamedialog_p.cpp PRE-CREATION 
>   kdeui/shortcuts/kstandardshortcut.h b31e45c 
>   kdeui/shortcuts/kstandardshortcut.cpp 669f750 
>   kdeui/widgets/khelpmenu.h 3389068 
>   kdeui/widgets/khelpmenu.cpp f547c46 
>   kdeui/xmlgui/ui_standards.rc a0f5bed 
> 
> Diff: http://git.reviewboard.kde.org/r/110367/diff/
> 
> 
> Testing
> -------
> 
> Ran okular, saw the new menu entry, it did stuff.
> Ran ksnapshot (that doesn't use xmlgui), saw the new menu entry, it did the same stuff.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130518/730eb71c/attachment.htm>