Review Request 110476: Call KNotification::close() when notification is closed in the applet

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110476/
-----------------------------------------------------------

(Updated May 16, 2013, 9:38 p.m.)


Review request for kde-workspace.


Description
-------

Call KNotification::close() when user clicks the 'X' button in the Notifications applet.

This prevents leaking persistent notifications and allows applications to depend on KNotification::closed() signal.


Diffs (updated)
-----

  plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml 64d9298 
  plasma/generic/applets/notifications/contents/ui/Notifications.qml c5be0a3 
  plasma/generic/dataengines/notifications/notificationaction.cpp 397073e 
  plasma/generic/dataengines/notifications/notificationsengine.cpp 25fccbb 

Diff: http://git.reviewboard.kde.org/r/110476/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130516/c20e7d1d/attachment.htm>