macro_log_feature : setting max version

Alexander Neundorf neundorf at kde.org
Thu May 16 20:38:41 BST 2013


On Thursday 16 May 2013, Valentin Rusu wrote:
> Hello,
> 
> This issue is triggered by kopete's OTR plugin that stopped compiling with
> LibOTR 4.0.0 because it undergone some imported structure changes.
> 
> Pali Rohar managed to modify the FindLibOTR.cmake, we now set-up a version
> range starting with 3.2.0 (initial requirement) to 4.0.0 and kopete
> compiles by excluding the offending, too recent, LibOTR.
> 
> However, the final cmake status outputs this :
> 
> ---------------------------------------------------------------------------
> -- -- The following OPTIONAL packages could NOT be located on your system.
> -- Consider installing them to enable more features from this software.
> --------------------------------------------------------------------------
> --- * libotr (3.2.0 or *higher*)  <http://www.cypherpunks.ca/otr>
>      A library to encrypt messages with Off-the-Record encryption (versions
> 3.2.0 to 4.0.0)
>      Required for the Kopete otr plugin.
> 
> I think tat a more elegant output message would state :
> 
> * libotr (3.2.0 to 4.0.0)
> 
> But the macro does not have a _maxVersion parameter. How about adding it?
> Would it be OK to add such a parameter?

I'd prefer not to add any new features to macro_log_feature().
Instead have a look at FeatureSummary.cmake coming with cmake.
Actually, I think FindPackageHandleStandardArgs.cmake does not support a 
version range, but "only" a minimum version.
This would be the first thing which needs to be improved for that.

Alex




More information about the kde-core-devel mailing list