Review Request 110327: KMessageWidget: Remove decoration icon

Aurélien Gâteau agateau at
Wed May 15 10:45:30 BST 2013

This is an automatically generated e-mail. To reply, visit:

(Updated May 15, 2013, 11:45 a.m.)

Review request for Dolphin, Kate and kdelibs.


Show the icon label *after* setting the pixmap


This avoids confusion between the decoration icon and the close button, especially when type is KMessageWidget::Error. This happens for example with Dolphin when an error happens while trying to connect to an non available host.
This change also has the nice side-effect of leaving more space for the widget text.

Diffs (updated)

  kdeui/widgets/kmessagewidget.h 80a9980e0af63185e032ca759800bb9fb32b1557 
  kdeui/widgets/kmessagewidget.cpp 724da0fa60a7b236d61685257e011fc49a30c1ff 



Tested with kmessagewidgetdemo, Dolphin and Kate.


Aurélien Gâteau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list