Review Request 110327: KMessageWidget: Remove decoration icon

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32506
-----------------------------------------------------------

Ship it!


Imo the patch looks good. So from my side it's a clear ship-it! :-)

- Dominik Haumann


On May 14, 2013, 2:31 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110327/
> -----------------------------------------------------------
> 
> (Updated May 14, 2013, 2:31 p.m.)
> 
> 
> Review request for Dolphin, Kate and kdelibs.
> 
> 
> Description
> -------
> 
> This avoids confusion between the decoration icon and the close button, especially when type is KMessageWidget::Error. This happens for example with Dolphin when an error happens while trying to connect to an non available host.
> This change also has the nice side-effect of leaving more space for the widget text.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/kmessagewidget.h 80a9980e0af63185e032ca759800bb9fb32b1557 
>   kdeui/widgets/kmessagewidget.cpp 724da0fa60a7b236d61685257e011fc49a30c1ff 
> 
> Diff: http://git.reviewboard.kde.org/r/110327/diff/
> 
> 
> Testing
> -------
> 
> Tested with kmessagewidgetdemo, Dolphin and Kate.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130514/5956ab90/attachment.htm>