Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

[Dawit Alemayehu]

> On May 13, 2013, 10:47 p.m., David Faure wrote:
> > dolphin/src/dolphinpart.cpp, line 463
> > <http://git.reviewboard.kde.org/r/108802/diff/5/?file=143487#file143487line463>
> >
> >     I don't understand the use of QPointer.
> >     Wouldn't it be enough to add m_removeAction = 0; after this line?
> >     
> >     
> >     The parent of the removeaction is "this", so surely there's no other way for the action to be automatically deleted. So the QPointer doesn't seem useful to me.
> >

That is laziness on my part. I wanted the QPointer to handle all of that for me. You are completely right that this overhead is unnecessary ; so I will fix it.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108802/#review32467
-----------------------------------------------------------


On May 13, 2013, 1:02 p.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108802/
> -----------------------------------------------------------
> 
> (Updated May 13, 2013, 1:02 p.m.)
> 
> 
> Review request for KDE Base Apps, David Faure and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This patch fixes DolphinPart such that the "Delete/Move To Trash" actions are automatically toggled if the user presses the Shift key and allows  https://git.reviewboard.kde.org/r/107509/ to be applied.
> 
> The code is completely based on what Dolphin's context menu does. Even though this works as planned, I still have reservations about the use of KModifierKeyInfo since every key press event from any application is sent to the application that connects to its signals. In my code and unlike what is done in Dolphin's context menu, I try to mitigate the impact of that by ignoring the signal when the part does not have the focus. Still if there is a better way to capture key press events at the part level I would like to use that instead. Any ideas ?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt ffb232c 
>   dolphin/src/dolphincontextmenu.h 1c65fab 
>   dolphin/src/dolphincontextmenu.cpp 89a169f 
>   dolphin/src/dolphinpart.h 7881ded 
>   dolphin/src/dolphinpart.cpp 627ba79 
>   dolphin/src/dolphinremoveaction.h PRE-CREATION 
>   dolphin/src/dolphinremoveaction.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108802/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit Alemayehu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130514/aff5f5a4/attachment.htm>