Review Request 110390: Do not set Phonon KCM as changed at startup when using PulseAudio

Jan Grulich grulja at gmail.com
Mon May 13 09:10:42 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110390/
-----------------------------------------------------------

(Updated May 13, 2013, 8:10 a.m.)


Review request for KDE Runtime, Casian Andrei, Colin Guthrie, and Harald Sitter.


Changes
-------

Ok, thanks, I've added them too.


Description
-------

This patch fixes a problem in Phonon KCM which is always set as changed when using PulseAudio. Previous solution emits ready() signal when some parts of AudioSetup are not initialized yet. And changed() signal is connected to soon so that's the reason why this KCM is always set as changed.


Diffs
-----

  phonon/kcm/audiosetup.cpp 35dc4ca 
  phonon/kcm/main.cpp 5d75cba 

Diff: http://git.reviewboard.kde.org/r/110390/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130513/89eb7334/attachment.htm>


More information about the kde-core-devel mailing list