Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

[Max Brazhnikov]

> On May 12, 2013, 9:21 a.m., Alexander Neundorf wrote:
> > There is a Find-module for libusb in extra-cmake-modules.
> > As long as this is not released yet, please use a copy from the one over there:
> > http://quickgit.kde.org/?p=extra-cmake-modules.git&a=blob&h=eba47115f94cc2eb969f19166d6664b300864a30&hb=316c7756ec1b0745f518d2f9af139812c3c5a24f&f=find-modules%2FFindLibUSB1.cmake

Thanks! but I need small modification, because on FreeBSD libusb1 has no '-1' suffix:
http://people.freebsd.org/~makc/patches/FindLibUSB1.cmake

Shall I open new request for extra-cmake-modules?

Max


- Max


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110271/#review32376
-----------------------------------------------------------


On May 11, 2013, 9:14 p.m., Max Brazhnikov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110271/
> -----------------------------------------------------------
> 
> (Updated May 11, 2013, 9:14 p.m.)
> 
> 
> Review request for kde-workspace.
> 
> 
> Description
> -------
> 
> Use libusb-1 to query info about usb devices in kinfocenter.
> Remove *BSD specific code: it doesn't work on all supported FreeBSD versions. In principle it can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for simplification.
> Remove polling and use DeviceNotifier instead.
> Add FindLibUSB-1.cmake
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindLibUSB-1.cmake PRE-CREATION 
>   kinfocenter/Modules/usbview/CMakeLists.txt 87bb256 
>   kinfocenter/Modules/usbview/config-kcmusb.h.cmake PRE-CREATION 
>   kinfocenter/Modules/usbview/kcmusb.cpp c598467 
>   kinfocenter/Modules/usbview/usbdevices.h 493caeb 
>   kinfocenter/Modules/usbview/usbdevices.cpp 9bd7033 
> 
> Diff: http://git.reviewboard.kde.org/r/110271/diff/
> 
> 
> Testing
> -------
> 
> I've tested it only on FreeBSD. It would nice to test at least FindLibUSB-1.cmake on other OSes.
> 
> 
> Thanks,
> 
> Max Brazhnikov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130512/e8fd8d1a/attachment.htm>