Review Request 110271: libusb-1 support in kcmusb (kinfocenter)

[Max Brazhnikov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110271/
-----------------------------------------------------------

(Updated May 11, 2013, 9:14 p.m.)


Review request for kde-workspace.


Changes
-------

Update FindLibUSB-1.cmake


Description
-------

Use libusb-1 to query info about usb devices in kinfocenter.
Remove *BSD specific code: it doesn't work on all supported FreeBSD versions. In principle it can be saved for NetBSD, but NetBSD could use libusb-1, thus drop it for simplification.
Remove polling and use DeviceNotifier instead.
Add FindLibUSB-1.cmake


Diffs (updated)
-----

  cmake/modules/FindLibUSB-1.cmake PRE-CREATION 
  kinfocenter/Modules/usbview/CMakeLists.txt 87bb256 
  kinfocenter/Modules/usbview/config-kcmusb.h.cmake PRE-CREATION 
  kinfocenter/Modules/usbview/kcmusb.cpp c598467 
  kinfocenter/Modules/usbview/usbdevices.h 493caeb 
  kinfocenter/Modules/usbview/usbdevices.cpp 9bd7033 

Diff: http://git.reviewboard.kde.org/r/110271/diff/


Testing
-------

I've tested it only on FreeBSD. It would nice to test at least FindLibUSB-1.cmake on other OSes.


Thanks,

Max Brazhnikov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20130511/dddeba92/attachment.htm>